Skip to content

Error cleanup #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kixelated merged 2 commits into from
Feb 12, 2026
Merged

Error cleanup #944

kixelated merged 2 commits into from
Feb 12, 2026
+4 −24

Conversation

@kixelated
Copy link
Collaborator

@kixelated kixelated commented Feb 12, 2026

No description provided.

@kixelated kixelated enabled auto-merge (squash) February 12, 2026 15:03
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 12, 2026

Walkthrough

This pull request adds the #[non_exhaustive] attribute to three public error enums across different modules: Error in rs/hang/src/error.rs, Error in rs/libmoq/src/error.rs, and DecodeError in rs/moq-lite/src/coding/decode.rs. Additionally, the Error enum in rs/hang/src/error.rs is refactored by removing six variants (DuplicateTrack, MissingTrack, InvalidSession, EmptyGroup, InvalidFrame, UnsupportedCodec) and introducing a new variant UnknownFormat(String). The changes affect error type declarations and exhaustiveness patterns without altering existing error handling logic in the remaining variants.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Error cleanup' is vague and generic, using a non-descriptive term that doesn't convey the specific changes made (removal of error variants, addition of non_exhaustive attributes, etc.). Consider a more specific title that describes the primary changes, such as 'Add non_exhaustive to error enums and refactor Error variants' or 'Refactor error types with non_exhaustive and remove deprecated variants'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to verify relevance to the changeset. Add a description explaining the purpose of the error cleanup, which variants were removed and why, and the rationale for marking enums as non_exhaustive.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch limit-api

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
rs/libmoq/src/error.rs (1)

104-124: Nit: error code -12 is skipped in the sequence.

The codes jump from -11 (DecodeFailed) to -13 (TimestampOverflow). This appears pre-existing and not introduced by this PR, but worth noting for future maintainability — a comment explaining the gap (e.g., a previously removed variant) would help prevent accidental reuse or confusion.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit 17cd30a into main Feb 12, 2026
1 check passed
@kixelated kixelated deleted the limit-api branch February 12, 2026 15:21
This was referenced Feb 12, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kixelated